Skip to content

feat: Added "build-tool" dist parameter and PEP517 build support#106

Merged
Jaryt merged 17 commits into
masterfrom
feat/build-dist
Sep 23, 2022
Merged

feat: Added "build-tool" dist parameter and PEP517 build support#106
Jaryt merged 17 commits into
masterfrom
feat/build-dist

Conversation

@Jaryt

@Jaryt Jaryt commented Sep 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Expand support of the dist command with the option to us newer standard build tool PEP517 build

Thanks to @kojiromike for #102 which this PR builds off of. We are opting to extend functionality rather than replace previous behavior, making this a minor change instead of major.

kojiromike and others added 8 commits September 22, 2022 17:57
@kojiromike @Jaryt
Use python -m build for PEP517 Compatibility (#102)
c589389 
* Use python -m build for PEP517 Compatibility

[build](https://pypa-build.readthedocs.io/en/latest/) is a simple,
correct PEP 517 build frontend. It invokes the PEP517 hooks, so projects
that support PEP 517, but not setuptools, will still build.

* Fix Typo

Co-authored-by: Jaryt Bustard <jarytbustard@gmail.com>
@Jaryt
feat: made build tool an option for dist
95c505f
@Jaryt
fix: revert function changes
1bbabe8
@Jaryt
fix: updated parameter references
a67aa06
@Jaryt
ci: added parameter to dist job
7c0e8c2
@Jaryt
ci: bump cache version
f8e748e
@Jaryt
ci: bump cache version
cf32e5a
@Jaryt
ci: remove outdated pipenv cache verification
661c699
@Jaryt Jaryt requested a review from a team as a code owner September 23, 2022 00:52
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:e3afda1feedd168f5e5e366af5a4816b94a62747

EricRibeiro
EricRibeiro suggested changes Sep 23, 2022
View reviewed changes

@EricRibeiro EricRibeiro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Very clean implementation of the new feature.

Comment thread .circleci/config.yml Outdated
Comment thread src/scripts/pypa-build.sh
Comment thread src/scripts/pypa-build.sh Outdated
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:6d4bf269895fe0843e028a6ce454b4965afc0bbb

EricRibeiro
EricRibeiro suggested changes Sep 23, 2022
View reviewed changes
Comment thread .circleci/test-deploy.yml
Comment thread src/scripts/pypa-build.sh
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:460a9e32d7bd528994c12aca04fcb87aaac0b53d

@kojiromike

kojiromike commented Sep 23, 2022

Copy link
Copy Markdown

Really excited to see this taking shape. Thanks for your hard work!

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:2b92ff611348c2848fc4832bd3b98d66aadce096

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:1f2d4db273a414b45bc13483ceb60befae7e8e88

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:6d73bfa5a62d25c279052647c333b403d0b6a2d1

@Jaryt Jaryt requested a review from EricRibeiro September 23, 2022 15:08
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:1f2d4db273a414b45bc13483ceb60befae7e8e88

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:3f7d434d8d59615c14aea0b903ef1773081cc6e2

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:5e3cf667062e786d038f4b1a52aea85522aca6df

@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:115942cc617e4ed74422556b2035f8ef7051be26

@EricRibeiro EricRibeiro changed the title feat: Addded "build-tool" dist parameter and PEP517 build support feat: Added "build-tool" dist parameter and PEP517 build support Sep 23, 2022
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:f791f954944957b05e1a2208d07f7db29af1cdb5

@Jaryt Jaryt merged commit 2d4e936 into master Sep 23, 2022
@Jaryt Jaryt deleted the feat/build-dist branch September 23, 2022 15:53
@orb-publisher

orb-publisher commented Sep 23, 2022

Copy link
Copy Markdown

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/python?version=dev:2d4e936cc848f26fcf4b3fe0908db8a04aa815d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jaryt @orb-publisher @kojiromike @EricRibeiro