Scheduler: refactor workspaces module (TS): part 6 by sjbur · Pull Request #33965 · DevExpress/DevExtreme

sjbur · 2026-06-11T11:13:51Z

No description provided.

sjbur · 2026-06-11T13:44:33Z


  protected getToday?(): Date;

-  protected $allDayPanel: any;


protected $allDayPanel: any;
private $allDayTitle: any;

were removed because they were not being used

both fields you mentioned are still defined and used

I see, think you meant
private allDayTitles!: any[];
private allDayPanels!: any[];

Copilot

Pull request overview

This PR continues the Scheduler workspace refactor (TS, part 5.2) by migrating the legacy m_work_space module to the new work_space entry and tightening types across workspace implementations, grouped strategies, shaders, and related tests.

Changes:

Switched imports/references from m_work_space to work_space throughout scheduler workspaces, strategies, shaders, and tests.
Refined TypeScript typings in work_space.ts (option access patterns, action maps, renderer/scroll sync typing, drag behavior config typing).
Updated workspace implementations (day/week/month/timeline/agenda) to use this.option() accessors consistently and adjusted a few rendering/DOM helper behaviors.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.markup-0.tests.js	Updates test import to the new workspace module path.
packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts	Core refactor: stronger typing, option access changes, scroll/selection/drag handling adjustments, new helper types.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_week.ts	Uses `option().type` / `option().startDate` accessors.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_month.ts	Updates imports + option accessors; minor iteration typing tweaks.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_indicator.ts	Updates import path + option destructuring.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_vertical.ts	Updates workspace import + option destructuring; adjusts element typing.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_horizontal.ts	Updates workspace import path.
packages/devextreme/js/__internal/scheduler/workspaces/work_space_day.ts	Uses `option().intervalCount`.
packages/devextreme/js/__internal/scheduler/workspaces/virtual_scrolling.ts	Updates workspace import path + TODO reference.
packages/devextreme/js/__internal/scheduler/workspaces/timeline.ts	Updates workspace import path + option accessors + grouped strategy call signature.
packages/devextreme/js/__internal/scheduler/workspaces/timeline_week.ts	Uses `option().type`.
packages/devextreme/js/__internal/scheduler/workspaces/timeline_month.ts	Uses `option()` accessors for templates/dates/interval.
packages/devextreme/js/__internal/scheduler/workspaces/agenda.ts	Updates workspace import path + option accessors; minor DOM collection handling changes.
packages/devextreme/js/__internal/scheduler/utils.ts	Exports `RenovationWidget` and adds `dispose` to its contract.
packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_vertical.ts	Updates workspace import path + removes unnecessary casts.
packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_horizontal.ts	Updates workspace import path.
packages/devextreme/js/__internal/scheduler/m_scheduler.ts	Updates TODO references from `m_work_space.ts` to `work_space.ts`.
packages/devextreme/js/__internal/scheduler/tests/workspace.base.test.ts	Updates workspace import path.
packages/devextreme/js/__internal/scheduler/tests/mock/mock_scheduler.ts	Updates workspace import path.

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated no new comments.

sjbur · 2026-06-11T16:58:14Z

  return button.id;
 });

-export const hasHorizontalScroll = async (container: Selector): Promise<boolean> => {


I had a failing test which was resolved by this edit.

✖ [T1225772]: should not have the horizontal scroll in horizontal views when the crossScrollingEnabled: true (view:day) (screenshots: /opt/actions-runner/_work/DevExtreme/DevExtreme/e2e/testcafe-devextreme/artifacts/failedtests/[T1225772] should not have the horizontal scroll in horizontal views when the crossScrollingEnabled true (viewday).png) (2.92s)

Selector does not have test controller access. To execute Selector from a Node.js API callback, bind the test controller object to the function with the .with({ boundTestRun: t }) method. Note that you cannot execute Selector outside test code.

Link to failing job: https://github.com/DevExpress/DevExtreme/actions/runs/27351988482/job/80830001051

sjbur · 2026-06-11T17:16:49Z

    if (this.isVerticalGroupedWorkSpace()) {
      return this.$groupTable;
    }

    return this.$thead;
  }

-  private getDateHeaderContainer() {


Also removed because was not being used

Copilot

Pull request overview

Copilot reviewed 48 out of 55 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated no new comments.

# Conflicts: # packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_horizontal.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_vertical.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.

# Conflicts: # packages/devextreme/js/__internal/scheduler/workspaces/timeline_week.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space_week.ts

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated no new comments.

refactor: refactor work_space

5d06cf1

sjbur self-assigned this Jun 11, 2026

sjbur marked this pull request as ready for review June 11, 2026 13:41

sjbur requested a review from a team as a code owner June 11, 2026 13:41

Copilot AI review requested due to automatic review settings June 11, 2026 13:41

Copilot started reviewing on behalf of sjbur June 11, 2026 13:42 View session

sjbur commented Jun 11, 2026

View reviewed changes

Copilot AI reviewed Jun 11, 2026

View reviewed changes

sjbur requested a review from Copilot June 11, 2026 14:09

Copilot started reviewing on behalf of sjbur June 11, 2026 14:09 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 11, 2026 15:58

sjbur force-pushed the issue-4500_26_1_v2_part2 branch from 74477a5 to 882cde1 Compare June 11, 2026 15:58

Copilot started reviewing on behalf of sjbur June 11, 2026 15:58 View session

web-flow added 9 commits June 11, 2026 17:59

fix: fix build

140a58f

fix: fix header class

5ed657b

refactor: remove // @ts-ignore

4ad272e

refactor: remove dead code

236c0b7

refactor: type options for workspaces module

5ed6bfe

fix: fix tests

92c9d62

refactor: small improvements

32b43a4

fix: try to fix hasHorizontalScroll method

317ed1d

fix: fix test

4649fda

Copilot AI reviewed Jun 11, 2026

View reviewed changes

sjbur force-pushed the issue-4500_26_1_v2_part2 branch from 882cde1 to 4649fda Compare June 11, 2026 16:20

sjbur changed the title ~~Scheduler: refactor workspaces module (TS): part 5.2~~ Scheduler: refactor workspaces module (TS): part 6 Jun 11, 2026

sjbur commented Jun 11, 2026

View reviewed changes

refactor: add proper type to _supportedKeys

f0e85f5

Copilot AI review requested due to automatic review settings June 11, 2026 17:22

sjbur requested review from a team as code owners June 12, 2026 10:09

github-actions Bot added the .d.ts label Jun 12, 2026

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 12, 2026 10:15

sjbur force-pushed the issue-4500_26_1_v2_part2 branch from 2d93113 to 42c80af Compare June 12, 2026 10:15

github-actions Bot removed the .d.ts label Jun 12, 2026

Copilot started reviewing on behalf of sjbur June 12, 2026 10:16 View session

sjbur force-pushed the issue-4500_26_1_v2_part2 branch from 42c80af to 5ac903d Compare June 12, 2026 10:20

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 12, 2026 10:21

Copilot started reviewing on behalf of sjbur June 12, 2026 10:22 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

web-flow added 2 commits June 12, 2026 13:27

fix: fix tests

9bea530

fix: fix tests

d95195c

Copilot AI review requested due to automatic review settings June 15, 2026 08:18

Copilot started reviewing on behalf of sjbur June 15, 2026 08:18 View session

sjbur requested a review from a team June 15, 2026 08:18

Copilot AI reviewed Jun 15, 2026

View reviewed changes

web-flow added 4 commits June 15, 2026 14:34

Merge branch '26_1' into issue-4500_26_1_v2_part2

e5ec225

# Conflicts: # packages/devextreme/js/__internal/scheduler/workspaces/timeline_week.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts # packages/devextreme/js/__internal/scheduler/workspaces/work_space_week.ts

refactor: review

f8a133c

refactor: review

f210b7d

refactor: review

448b1cb

Copilot AI review requested due to automatic review settings June 15, 2026 13:31

Copilot started reviewing on behalf of sjbur June 15, 2026 13:31 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

fix: fix tests

894321d

sjbur force-pushed the issue-4500_26_1_v2_part2 branch from 64880b1 to 894321d Compare June 15, 2026 13:48

Conversation

sjbur commented Jun 11, 2026

Uh oh!

sjbur Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sjbur Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

sjbur Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants