PivotGrid: remove tabindex from fieldChooser dxScrollable#33973
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts PivotGrid FieldChooser’s internal dxScrollable configuration to remove an extra keyboard Tab stop (tabindex) from the scrollable container and updates the corresponding keyboard-navigation E2E test expectations.
Changes:
- Disable Scrollable keyboard mode for FieldChooser area lists to prevent the scrollable container from becoming tabbable.
- Update the FieldChooser Tab-traversal E2E test to account for the removed Tab stop.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser.ts | Sets useKeyboard: false on the area list dxScrollable to remove tabindex/Tab stop. |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | Updates Tab key press counts for FieldChooser traversal after focus order change. |
Comment on lines
586
to
589
| $fieldsContainer.dxScrollable({ | ||
| useNative: false, | ||
| useKeyboard: false, | ||
| }); |
Contributor
There was a problem hiding this comment.
we don't need it for KBN. scrollables have focusable elements inside
Tucchhaa
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.