Use std::array/std::vector in inspect_file and apply CTAD for std::atomic in multithread example#101
Merged
Easton97-Jens merged 1 commit intoApr 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
InspectFileoperator by replacing raw C arrays andconst_castusage with safer C++ containers and APIs.std::atomicinmultithreadto reduce verbosity and silences potential warnings.Description
int pipefd[2]withstd::array<int, 2>and usepipefd.data()forpipe()to avoid C-style arrays inInspectFile.char *argv[]andconst_castusage withstd::vector<std::string>and astd::vector<char*>forposix_spawnarguments to keep argument storage alive and eliminate unsafe casts.char buff[512]withstd::array<char, 512>and updated the read loop to usebuff.data()/buff.size()and an explicit loop-control flag for clearer EINTR handling.std::atomic<int> completed_threads{0};with class template argument deductionstd::atomic completed_threads{0};inexamples/multithread.Testing
cmake/make) which completed successfully.ctest) and the tests passed without regressions.examples/multithreadsmoke test which started, completed threads, and reported elapsed time successfully.Codex Task