Skip to content

Unify the gradient chain lookup used by the stops and attribute reads#4223

Merged
Keavon merged 1 commit into
GraphiteEditor:masterfrom
YohYamasaki:unify-gradient-chain-lookup
Jun 11, 2026
Merged

Unify the gradient chain lookup used by the stops and attribute reads#4223
Keavon merged 1 commit into
GraphiteEditor:masterfrom
YohYamasaki:unify-gradient-chain-lookup

Conversation

@YohYamasaki

Copy link
Copy Markdown
Contributor

Fixes a bug introduced by #4177.

The node-finding logic for "Gradient Value" and other gradient-related attribute insertion nodes (e.g. "Gradient Type") was different, so the gradient tool could target the wrong Fill input in a case where there were multiple 'Fill' nodes. This PR unifies the logic for finding the Fill node that only affects the actual painting.

Before

Screen.Recording.2026-06-11.at.10.57.50.mov

After

Screen.Recording.2026-06-11.at.11.54.13.mov

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates get_upstream_gradient_value_node_id to find the upstream gradient node by walking from the target input's upstream output connector using a horizontal flow. The reviewer suggested refactoring this logic into a generic helper function to improve code reuse and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Keavon

Keavon commented Jun 11, 2026

Copy link
Copy Markdown
Member

!build (Run ID 27322003460)

@github-actions

Copy link
Copy Markdown
📦 Web Build Complete for 47abd7e
https://ad1db9b3.graphite.pages.dev

Wasm: 22.99 MB — JS: 0.44 MB — CSS: 0.09 MB — Fonts: 0.30 MB — Images: 0.09 MB — All Assets: 23.92 MB

@Keavon Keavon force-pushed the unify-gradient-chain-lookup branch from 47abd7e to 33dcec0 Compare June 11, 2026 05:33
@Keavon Keavon enabled auto-merge June 11, 2026 05:33
@Keavon Keavon added this pull request to the merge queue Jun 11, 2026
Merged via the queue into GraphiteEditor:master with commit 26a0b90 Jun 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants