Unify the gradient chain lookup used by the stops and attribute reads#4223
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates get_upstream_gradient_value_node_id to find the upstream gradient node by walking from the target input's upstream output connector using a horizontal flow. The reviewer suggested refactoring this logic into a generic helper function to improve code reuse and maintainability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
!build (Run ID 27322003460) |
Wasm: 22.99 MB — JS: 0.44 MB — CSS: 0.09 MB — Fonts: 0.30 MB — Images: 0.09 MB — All Assets: 23.92 MB |
47abd7e to
33dcec0
Compare
Fixes a bug introduced by #4177.
The node-finding logic for "Gradient Value" and other gradient-related attribute insertion nodes (e.g. "Gradient Type") was different, so the gradient tool could target the wrong Fill input in a case where there were multiple 'Fill' nodes. This PR unifies the logic for finding the Fill node that only affects the actual painting.
Before
Screen.Recording.2026-06-11.at.10.57.50.mov
After
Screen.Recording.2026-06-11.at.11.54.13.mov