Fix CO5300 updates when using 180-degree rotation#1623
Closed
kitazaki wants to merge 1 commit into
Closed
Conversation
## Summary This change removes the separate synchronous color-transfer path for `rotation == 2` and routes it through the same color send flow used by the normal orientation. For 180-degree rotation, the update window is still adjusted per chunk based on the remaining update lines. ## Changes - Set the CO5300 update window per transferred chunk for `rotation == 2` - Reuse the existing async color transfer / queue handling in `co5300Send` - Remove the dedicated `co5300SendHardwareRotated180` helper
Collaborator
|
This has been merged and will be available in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the separate synchronous color-transfer path for
rotation == 2and routes it through the same color send flow used by the normal orientation. For 180-degree rotation, the update window is still adjusted per chunk based on the remaining update lines.Changes
rotation == 2co5300Sendco5300SendHardwareRotated180helper