refactor: replace regex datetime parsing with fromisoformat, closes #191#303
Open
phanak-sap wants to merge 1 commit into
Open
refactor: replace regex datetime parsing with fromisoformat, closes #191#303phanak-sap wants to merge 1 commit into
phanak-sap wants to merge 1 commit into
Conversation
b134c11 to
a2f6d6a
Compare
- Replace the regexp-based ISO datetime parsing introduced in #184 and the strptime fallback chain in parse_datetime_literal with datetime.fromisoformat. - Fixes the non-padded test fixture '2038-01-19T3:14:7' to valid ISO 8601. - Improve test coverage for sub-6-digit fractional seconds, no-seconds-with-offset, microseconds with Z suffix, and None inputs for both Edm.DateTime and Edm.DateTimeOffset after considered the Odata V2 specification for those types.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the regexp-based ISO datetime parsing introduced in model: fix timezone handling for Edm.DateTimeOffset #184 and the strptime fallback chain in parse_datetime_literal with datetime.fromisoformat.
Fixes the non-padded test fixture '2038-01-19T3:14:7' to valid ISO 8601.
Improve test coverage for sub-6-digit fractional seconds, no-seconds-with-offset, microseconds with Z suffix, and None inputs for both Edm.DateTime and Edm.DateTimeOffset after considered the Odata V2 specification for those types.