service, vendor.SAP: add response_hook for pre-handler response inspection#305
Open
phanak-sap wants to merge 1 commit into
Open
service, vendor.SAP: add response_hook for pre-handler response inspection#305phanak-sap wants to merge 1 commit into
phanak-sap wants to merge 1 commit into
Conversation
4d5ea9f to
50c425f
Compare
…ction - Add an optional response_hook=None parameter to Service and Client response_hook fires inside _call_handler() before the domain handler runs, covering both execute() and async_execute(). The hook is a stateless Callable[[response], None]; raising from it propagates to the caller and suppresses the domain result. No HTTP networking objects cross the OData API boundary. - Add sap_header_error_hook() to pyodata.vendor.SAP reads the sap-message response header and raises BusinessGatewayError when severity is "error". - Update tests and documentation accordingly
50c425f to
799ff67
Compare
Contributor
Author
|
Left as open question for reviewers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional response_hook=None parameter to Service and Client
response_hook fires inside _call_handler() before the domain handler runs, covering both execute() and async_execute(). The hook is a stateless Callable[[response], None]; raising from it propagates to the caller and suppresses the domain result. No HTTP networking objects cross the OData API boundary.
Add sap_header_error_hook() to pyodata.vendor.SAP
reads the sap-message response header and raises BusinessGatewayError when severity is "error".
Update tests and documentation accordingly