fix: Omit NULL values from build side of hash joins#22893
Open
neilconway wants to merge 1 commit into
Open
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NullEqualsNothing#22875Rationale for this change
Previously,
HashMap-backed hash joins included NULLs butArrayMap-backed hash joins omitted them. UnderNullEqualsNothing, we can safely omit rows that have a NULL in any of their join keys, because they will never contribute to the output of the join. Omitting NULLs reduces the size of the build-side hash table.The previous probe behavior also resulted in searching the hash table for probe rows with NULLs in their join keys. This was wasted work; indeed, because all NULL build rows will end up in the same hash chain, this could actually be very expensive for joins over NULL-heavy data sets. For example, joining two 10k tables on all-NULL join keys took ~6 seconds (!). That drops to a few milliseconds after this PR.
What changes are included in this PR?
HashMapAre these changes tested?
Yes; new tests added.
Are there any user-facing changes?
No.