SOLR-18110: Remove deprecated attributes for telemetry#4524
Open
utsav00 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes deprecated OpenTelemetry attribute keys (http.status_code, http.method) from Solr tracing code and updates documentation/release notes to reflect the removal as part of Solr 10 upgrade guidance.
Changes:
- Removed deprecated
http.method/http.status_codeattribute keys and stopped emitting them inTraceUtils. - Added Solr 10 upgrade note describing the removal and the replacement attributes to use.
- Added an unreleased changelog entry for SOLR-18110.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc | Documents removal of deprecated telemetry tags and recommended replacements. |
| solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java | Stops setting deprecated span attributes; keeps only the newer semantic convention keys. |
| changelog/unreleased/SOLR-18110-remove-deprecated-tracing-attributes.yml | Adds release note entry for the removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@epugh, can you approve the pending workflows here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18110
Description
Simply removed deprecated annotated attributes and references
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.