Skip to content

Fix false positives in RULE-0-0-1 from disconnected non-Stmt CFG nodes#1144

Draft
castler wants to merge 1 commit into
github:mainfrom
castler:fix_0_0_1_with_orphan_blocks
Draft

Fix false positives in RULE-0-0-1 from disconnected non-Stmt CFG nodes#1144
castler wants to merge 1 commit into
github:mainfrom
castler:fix_0_0_1_with_orphan_blocks

Conversation

@castler

@castler castler commented Jun 19, 2026

Copy link
Copy Markdown

Description

The codeql/cpp-all library (particularly version 5.0.0) can produce orphan BasicBlock nodes in the CFG that are completely disconnected (no predecessors and no successors). These nodes represent expressions, variable accesses, or function name nodes rather than actual statements. When they appear in functions with virtual calls returning complex types (like expected<void, E>), the isReachable predicate cannot reach them and they get incorrectly flagged as unreachable statements.

Add isDisconnectedNonStmtBlock predicate to filter out these CFG artifacts. The predicate specifically targets blocks that:

  • Have no predecessors AND no successors (completely isolated)
  • Are not function entry points
  • Are not Stmt instances (the rule is about unreachable statements)

This preserves detection of legitimate unreachable statements (e.g., code after infinite loops or noreturn calls) which are Stmt nodes with zero predecessors but may have successors.

Verified: eliminates ~1182 false positives on eclipse-score/communication codebase while all existing test cases continue to pass.

Fixes #1143

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • RULE-0-0-1

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

The codeql/cpp-all library (particularly version 5.0.0) can produce orphan
BasicBlock nodes in the CFG that are completely disconnected (no predecessors
and no successors). These nodes represent expressions, variable accesses, or
function name nodes rather than actual statements. When they appear in
functions with virtual calls returning complex types (like expected<void, E>),
the isReachable predicate cannot reach them and they get incorrectly flagged
as unreachable statements.

Add isDisconnectedNonStmtBlock predicate to filter out these CFG artifacts.
The predicate specifically targets blocks that:
- Have no predecessors AND no successors (completely isolated)
- Are not function entry points
- Are not Stmt instances (the rule is about unreachable *statements*)

This preserves detection of legitimate unreachable statements (e.g., code
after infinite loops or noreturn calls) which are Stmt nodes with zero
predecessors but may have successors.

Verified: eliminates ~1182 false positives on eclipse-score/communication
codebase while all existing test cases continue to pass.

Fixes github#1143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RULE-0-0-1: False positives from orphan CFG BasicBlocks on virtual calls returning std::variant-based types

1 participant