Remove "Section x" headings#364
Conversation
| margin-top: $spacer-6 * 2; | ||
| } | ||
| } | ||
| h2:nth-of-type(2):before { content: "Section 2"; } |
There was a problem hiding this comment.
It could be fun to integrate i18n w/ SCSS ^^
There was a problem hiding this comment.
|
I like how these visually anchor each of the sections, so I would be sad to see them go. But understand if it's necessary for i18n. Some ideas of alternatives:
|
Yeah, I felt the same. I experimented with a few other visual anchors, but didn't find anything that felt right.
Do all languages use Arabic numbers and put them after the label? I'm not sure, but we should probably make the entire string localizable.
That works too. I'm fine with either of these options. Do you have a preference? |
The latter (just a number) seems less likely to break, so I'd choose that! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The "Section x" headings are currently implemented in CSS, which is not very friendly to i18n support (#295). There are a few workarounds (like moving the labels into the content, or adding selectors for each language like
html[lang=en] h2:before), but I'm not sure the added complexity is worth it.What do you think about removing them entirely?
@sophshep
Before
After