Simplify ScriptServer::get_global_class_list

[YYF233333]

The implementation of this function is rather awkward: it first copies the elements into a List, then copies them again into r_global_classes. We can simply return the intermediate List so that users can use it directly.

Since I was already working on this code, I also took the opportunity to tidy up some variable names and change unnecessary Lists to LocalVectors.

[Ivorforce]

Considering this use-case, I'd probably keep using a parameter (instead of returning a new list), but make it use LocalVector for both get_class_list and get_global_class_list. You can use SortArray to sort just the subsection of the newly added elements to preserve behavior.

[YYF233333]

Change as suggested. I'm not sure if I should change get_class_list to use SortArray, it currently sort all values in the list (although I think it is always given an empty list). Not sure which meaning is correct.

[Ivorforce]

I think it's fine, especially since the other one only sorts the added elements. Fingers crossed nothing relies on the previous behavior.

[YYF233333]

Add a comment to clarify the current behavior of these functions.

[Ivorforce]

Looks good to me.

[Ivorforce]

I'm not sure why it has to be moved to back, but if it has an effect on which other classes can register properties on it, we probably shouldn't move the final element into its place. Instead, the element should be removed and then re-added to back (same as move_to_back).

[YYF233333]

Sorry, my bad. I must have misunderstood how move_to_back is implemented. Fixed.

[Ivorforce]

I think it's fine, especially since the other one only sorts the added elements. Fingers crossed nothing relies on the previous behavior.

[Repiteo]

Thanks!