[TextServer] Shape emojis as separate runs.#110194
Merged
Merged
Conversation
Calinou
approved these changes
Sep 2, 2025
Calinou
left a comment
Member
There was a problem hiding this comment.
Code looks good to me.
Did you mean "runes" instead of "runs" in the commit message though?
Member
Author
Nop, "run" as a sequence of characters to shape, emojis are assigned a dedicated script code and therefore shaped on their own, not with the surrounding text. |
Contributor
|
Thanks! |
This was referenced Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110143
Before:
After:
