You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WhalesState
changed the title
Fix TextEdit drawing both normal and read_only styles together
Fix uneditable TextEdit draws both normal and read_only styles together
Sep 15, 2025
WhalesState
changed the title
Fix uneditable TextEdit draws both normal and read_only styles together
Fix editor theme scaled margins and TextEdit read_only drawing.
Sep 22, 2025
I think affecting all editor theme styleboxes is out of scope for this PR that was about the TextEdit readonly style. It was already approved too, I think these new changes would be better in a new PR to be reviewed separately.
Removed editor theme changes, also removed ceiling the margins which still fixes the text clipping issue but will report minimum size + 1 instead of -1 when left/right margin has values that can be rounded up.
also removed ceiling the margins which still fixes the text clipping issue but will report minimum size + 1 instead of -1 when editor scale is %50 or %150 which is fine for now.
This reverts #105870 so it reintroduces an issue and needs more consideration.
I think it should be a separate change so we can focus on allowing this PR to merge with just the read only change.
This reverts #105870 so it reintroduces an issue and needs more consideration. I think it should be a separate change so we can focus on allowing this PR to merge with just the read only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.