Skip to content

Metal: Fix Metal compiler version inspection#110873

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
stuartcarnie:fix_metal_baker
Sep 30, 2025
Merged

Metal: Fix Metal compiler version inspection#110873
Repiteo merged 1 commit into
godotengine:masterfrom
stuartcarnie:fix_metal_baker

Conversation

@stuartcarnie

@stuartcarnie stuartcarnie commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Summary

The shell command was failing to execute due to incorrect argument order.

Closes #110870

@stuartcarnie stuartcarnie requested a review from a team as a code owner September 24, 2025 20:12
@akien-mga

Copy link
Copy Markdown
Member

See also #110874 which was just opened.

@clayjohn

Copy link
Copy Markdown
Member

The change seems great, but are you sure it closes #110560? The OP of that was on Windows and this PR only applies to Metal.

Maybe you meant to link #110870?

@stuartcarnie

Copy link
Copy Markdown
Contributor Author

@clayjohn you're right, though I think I was initially testing that one as I was tagged, and later came across #110870

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@Repiteo Repiteo merged commit 4a1c1c4 into godotengine:master Sep 30, 2025
20 checks passed
@Repiteo

Repiteo commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Thanks!

@Repiteo

Repiteo commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked to 4.5

@Repiteo Repiteo removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 30, 2025
@stuartcarnie stuartcarnie deleted the fix_metal_baker branch October 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shader Baker failing to compile .metallib on macOS: Unable to determine toolchain properties to compile .metallib

5 participants