Fix IsStaticallyResolvable#111523
Merged
Merged
Conversation
paulloz
approved these changes
Oct 16, 2025
paulloz
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I think this is a better implementation, and applying it on fields makes sense.
Thank you!
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111370.
In #104135, the
IsStaticallyResolvablemethod was added to avoid trying to statically reference primary constructor parameters in property default values.This pull request does the following:
IsStaticallyResolvablecall to fields as well.IsStaticallyResolvableis changed to support more expression types (e.g.2 * Mathf.Pi) by, instead of checking lots of supported types of expressions, instead only checks sub-expressions for local variable or parameter references.