Skip to content

Add "with" stop word to the editor property name processor#111742

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
Calinou:editor-capitalization-add-stop-word
Dec 2, 2025
Merged

Add "with" stop word to the editor property name processor#111742
akien-mga merged 1 commit into
godotengine:masterfrom
Calinou:editor-capitalization-add-stop-word

Conversation

@Calinou

@Calinou Calinou commented Oct 16, 2025

Copy link
Copy Markdown
Member

This makes properties such as "Convert Colors with Editor Theme" have better-looking capitalization in the inspector and import options.

I noticed this while working on godotengine/godot-docs#11381.

PS: This is stated above the list:

// The following initialization is parsed in `editor/translations/scripts/common.py` with a regex.
// The word definition format should be kept synced with the regex.

However, I can't find this file in the current master branch. Is the comment still up-to-date? cc @akien-mga

Preview

Before

Screenshot_20251016_222113

After

Screenshot_20251016_222347

@Calinou Calinou added this to the 4.x milestone Oct 16, 2025
@Calinou Calinou requested a review from a team October 16, 2025 20:35
@RedMser

RedMser commented Oct 18, 2025

Copy link
Copy Markdown
Contributor

However, I can't find this file in the current master branch. Is the comment still up-to-date?

@Calinou I believe it is now here: https://github.com/godotengine/godot-editor-l10n/blob/main/scripts/common.py

@Calinou

Calinou commented Oct 18, 2025

Copy link
Copy Markdown
Member Author

@Calinou I believe it is now here: godotengine/godot-editor-l10n@main/scripts/common.py

That seems to be it. It looks like I don't need to update the regex (I thought it included every word).

I've updated the PR to update the link to the file that should be updated.

This makes properties such as "Convert Colors with Editor Theme"
have better-looking capitalization in the inspector and import options.
@Calinou Calinou force-pushed the editor-capitalization-add-stop-word branch from a6c6905 to b0c8c95 Compare October 18, 2025 16:42

@KoBeWi KoBeWi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao there is a whole guideline on whether with should be capitalized or not and it depends on the convention: https://titlecaseconverter.com/blog/is-with-capitalized/

I think it's fine either way and the implementation looks ok, but this is going to break property translations, which is something to be considered.

@akien-mga akien-mga modified the milestones: 4.x, 4.6 Dec 2, 2025
@akien-mga akien-mga merged commit fede398 into godotengine:master Dec 2, 2025
20 checks passed
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@Calinou Calinou deleted the editor-capitalization-add-stop-word branch December 3, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants