Add "with" stop word to the editor property name processor#111742
Conversation
@Calinou I believe it is now here: https://github.com/godotengine/godot-editor-l10n/blob/main/scripts/common.py |
That seems to be it. It looks like I don't need to update the regex (I thought it included every word). I've updated the PR to update the link to the file that should be updated. |
This makes properties such as "Convert Colors with Editor Theme" have better-looking capitalization in the inspector and import options.
a6c6905 to
b0c8c95
Compare
KoBeWi
left a comment
There was a problem hiding this comment.
lmao there is a whole guideline on whether with should be capitalized or not and it depends on the convention: https://titlecaseconverter.com/blog/is-with-capitalized/
I think it's fine either way and the implementation looks ok, but this is going to break property translations, which is something to be considered.
|
Thanks! |
This makes properties such as "Convert Colors with Editor Theme" have better-looking capitalization in the inspector and import options.
I noticed this while working on godotengine/godot-docs#11381.
PS: This is stated above the list:
However, I can't find this file in the current
masterbranch. Is the comment still up-to-date? cc @akien-mgaPreview
Before
After