Return at invalid skeleton in ChainIK3D before updating mutable info#114062
Merged
Conversation
fire
reviewed
Dec 19, 2025
TokageItLab
approved these changes
Dec 20, 2025
Member
There was a problem hiding this comment.
Needs to rebase to follow our PR workflow (this PR must contain only 1 commit).
94afb0c to
91dd0d8
Compare
Contributor
Author
the commit part is done :) |
Member
|
Ideally, we recommend that the commit comment shouldn’t contain any PR number, and based on the what you done. For example, “Make update_mutable_info return earlier if skeleton is null”. |
Member
|
The current title of the pull request is a good example of a commit message.
|
91dd0d8 to
4609ba7
Compare
Contributor
Author
|
assuming nothing broke in the amend it should be good now (not a huge fan of needing a force push to amend) |
Member
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretty self explanatory i hope.. in my testing it fixes the segfault reported in #114059 when moving a ChainIK3D derived node from its parent skeleton in the editor's scene tree
edit:
been trying to find an alternative way of doing this and couldn't really find one that was a solid fix, it seems like for some reason the function that caused the segfault gets called a few times once its gone from the skeleton's hierarchy.
either way it's probably a good idea to return when the skeleton is invalid because right after the skeleton check it's getting referenced