Skip to content

Remove amplification & mesh shader deny flags on D3D12.#114615

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
blueskythlikesclouds:remove-deny-flag-d3d12
Jan 5, 2026
Merged

Remove amplification & mesh shader deny flags on D3D12.#114615
akien-mga merged 1 commit into
godotengine:masterfrom
blueskythlikesclouds:remove-deny-flag-d3d12

Conversation

@blueskythlikesclouds

Copy link
Copy Markdown
Member

Should fix #114613.

The amplification & mesh shaders were introduced in a later D3D12 runtime, so older Windows 10 versions may not recognize these flags and fail root signature creation.

The absence of these flags make no performance difference since the shader stages don't exist in the pipelines in the first place.

@blueskythlikesclouds blueskythlikesclouds requested a review from a team as a code owner January 5, 2026 08:22
@akien-mga akien-mga added this to the 4.6 milestone Jan 5, 2026
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 5, 2026
@dasasdhba

Copy link
Copy Markdown

wow this works for me, thank you for such a quick fix :)

@akien-mga akien-mga merged commit 71112a2 into godotengine:master Jan 5, 2026
20 checks passed
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@akien-mga

Copy link
Copy Markdown
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
@blueskythlikesclouds blueskythlikesclouds deleted the remove-deny-flag-d3d12 branch January 15, 2026 09:16
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
…e-deny-flag-d3d12

Remove amplification & mesh shader deny flags on D3D12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3D12 Crashes due to SPIR-V parsing error only on specific laptop

4 participants