Skip to content

Reword OpenXR initialization failure alert message#114630

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
ashwinvbs:openxr_error_reword
Jan 6, 2026
Merged

Reword OpenXR initialization failure alert message#114630
akien-mga merged 1 commit into
godotengine:masterfrom
ashwinvbs:openxr_error_reword

Conversation

@ashwinvbs

Copy link
Copy Markdown
Contributor

Changes account for the following

  1. OpenXR initialization can fail if a required extension is unsupported.
  2. Logs contain more detailed info regarding failure.
  3. Add additional newlines to separate message into 4 sections Error encountered Editor specific hint to developer WMR specific hint Consequence

@ashwinvbs ashwinvbs requested a review from a team as a code owner January 5, 2026 20:03

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These changes make sense to me

Comment thread modules/openxr/register_types.cpp Outdated
@dsnopek dsnopek added this to the 4.x milestone Jan 5, 2026
Changes account for the following
1. OpenXR initialization can fail if a required extension is unsupported.
2. Logs contain more detailed info regarding failure.
3. Add additional newlines to separate message into 4 sections
   Error encountered
   Editor specific hint to developer
   WMR specific hint
   Consequence
@ashwinvbs ashwinvbs force-pushed the openxr_error_reword branch from 266d783 to b987c43 Compare January 6, 2026 03:57
@akien-mga akien-mga modified the milestones: 4.x, 4.6 Jan 6, 2026
@akien-mga akien-mga merged commit 28b0151 into godotengine:master Jan 6, 2026
20 checks passed
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@ashwinvbs ashwinvbs deleted the openxr_error_reword branch January 6, 2026 15:08
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
Reword OpenXR initialization failure alert message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants