Core: Fix implicit conversions in ContainerTypeValidate#114808
Merged
akien-mga merged 1 commit intoJan 9, 2026
Merged
Conversation
dalexeev
commented
Jan 9, 2026
Member
- Fixes 4.6 cannot cast raw nested arrays to Array[PackedInt32Array] #114299.
akien-mga
approved these changes
Jan 9, 2026
Ivorforce
approved these changes
Jan 9, 2026
Member
There was a problem hiding this comment.
I checked the git history. Seems like this part of the code organically grew from issue to issue. It makes sense to me to support all implicit conversion, not some arbitrary selection of it.
Note that the Variant::construct call will be significantly slower than the previous implementation. I recommend measuring if this makes a difference, since this affects most typed array / dictionary functions.
(mental note: In the future, Variant::construct should probably be reimplemented with better performance in mind)
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…-conv-in-container-type-validate Core: Fix implicit conversions in `ContainerTypeValidate`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.