fix(models): avoid spurious UserWarning on tool-call responses in _build_response_log#6073
Open
syedjafri06193 wants to merge 1 commit into
Open
fix(models): avoid spurious UserWarning on tool-call responses in _build_response_log#6073syedjafri06193 wants to merge 1 commit into
syedjafri06193 wants to merge 1 commit into
Conversation
…ild_response_log Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Response from ADK Triaging Agent Hello @syedjafri06193, thank you for creating this PR! To help us review your contribution more efficiently, please address the following items from our contribution guidelines:
These details will save review time and help us merge your changes sooner. Thank you! |
Author
|
CLA is signed (Google Individual CLA, Jun 08 2026). Requesting CLA check re-run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4685.
When the model returns a tool-call (function-call) response,
resp.textinternally iterates allPartobjects and emits aUserWarningfor every part that contains aFunctionCallinstead of plain text. This warning is unhelpful noise when the caller is just building a debug log string._safe_response_text(resp)before_build_response_log()that extracts text by directly iteratingcandidates[0].content.partsand joining onlypart.textvalues that are notNone, bypassing the warning-emitting property entirely.{resp.text}in_build_response_log()'s f-string with{_safe_response_text(resp)}.Test plan
UserWarning: there is no text partappears in logs.pytest tests/unittests/models/passes without new failures.🤖 Generated with Claude Code