Add googletest to python deps script#20
Closed
MichealReed wants to merge 3 commits into
Closed
Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
03f0293 to
7e0e8a8
Compare
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Without this dependency, automated builds will error since the third_party/googletest folder does not have a CMakeLists.txt or is required somewhere and should not be. This is an imported pull request from #20 GITHUB_PR_HEAD_SHA=3c4eed2eb3d1fa06ffdea2eb7be63529269a1b05 ORIGINAL_AUTHOR=MichealReed <micheal.reed@outlook.com> GitOrigin-RevId: f262db9 Change-Id: Ifde416b3c4bd016024d9993aab777a697e2f6128 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/201818 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
|
🚀 PR was merged in 0552b21! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this dependency, automated builds will error since the third_party/googletest folder does not have a CMakeLists.txt or is required somewhere and should not be.