Skip to content

deps: patch V8 to 6.4.388.44#18687

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:V8-6.4.388.44
Closed

deps: patch V8 to 6.4.388.44#18687
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:V8-6.4.388.44

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 9, 2018
@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

@MylesBorins

Copy link
Copy Markdown
Contributor Author

One more CI... boy has it been weird this weekend

https://ci.nodejs.org/job/node-test-pull-request/13113/

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@MylesBorins

Copy link
Copy Markdown
Contributor Author

rebased against master... one more run

https://ci.nodejs.org/job/node-test-pull-request/13127/

@MylesBorins

Copy link
Copy Markdown
Contributor Author

openssl link failure is an infra flake. re running the ppc test

https://ci.nodejs.org/job/node-test-commit-plinux/15343/

@MylesBorins

MylesBorins commented Feb 13, 2018

Copy link
Copy Markdown
Contributor Author

ppc test is green

landed in b6000d8

MylesBorins added a commit that referenced this pull request Feb 13, 2018
PR-URL: #18687
Refs: v8/v8@6.4.388.42...6.4.388.44
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18687
Refs: v8/v8@6.4.388.42...6.4.388.44
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants