doc: add changes entry for vm code generation options#19440
Closed
TomCoded wants to merge 2 commits into
Closed
Conversation
Add changes entries for vm.createContext codeGeneration option and script.runInNewContext contextCodeGeneration option. fixes: nodejs#19419 refs: nodejs#19016
4 tasks
lpinca
reviewed
Mar 19, 2018
| changes: | ||
| - version: REPLACEME | ||
| pr-url: https://github.com/nodejs/node/pull/19016 | ||
| description: The `contextCodeGeneration` option is supported now. |
Member
There was a problem hiding this comment.
Nit: can you please keep this aligned with pr-url? Shift left by 4 spaces.
| changes: | ||
| - version: REPLACEME | ||
| pr-url: https://github.com/nodejs/node/pull/19016 | ||
| description: The `codeGeneration` option is supported now. |
cjihrig
approved these changes
Mar 19, 2018
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nits addressed.
lpinca
approved these changes
Mar 19, 2018
Member
devsnek
approved these changes
Mar 20, 2018
TimothyGu
approved these changes
Mar 20, 2018
jasnell
approved these changes
Mar 20, 2018
Member
|
Landed in 54fbbb1, thank you! |
tniessen
pushed a commit
that referenced
this pull request
Mar 25, 2018
Add changes entries for vm.createContext codeGeneration option and script.runInNewContext contextCodeGeneration option. PR-URL: #19440 Fixes: #19419 Refs: #19016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add changes entries for vm.createContext codeGeneration
option and script.runInNewContext contextCodeGeneration
option.
fixes: #19419
refs: #19016
Checklist