test: move test-http-dump-req-when-res-end to sequential

[Trott]

The implementataion is sensitive to system resource availability, so
move it to sequential instead of running out of parallel directory.

Fixes: #19139

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/14065/

[lpinca]

Moving it to sequential != fix

[Trott]

Moving it to sequential != fix

I'm open to other verbs. "mitigate"? "work around"? Something else?

[lpinca]

"test: move http-dump-req-when-res-ends to sequential" ?

[Trott]

"test: move http-dump-req-when-res-ends to sequential"

Works for me!

[lpinca]

FWIW the test is using common.mustNotCall instead of common.mustNotCall().

node/test/parallel/test-http-dump-req-when-res-ends.js

Line 19 in 49e9893

req.on('end', common.mustNotCall);

[Trott]

FWIW the test is using common.mustNotCall instead of common.mustNotCall().

Ugh, and fixing that causes the test to fail...

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/14069/

[lpinca]

cc: @mcollina as the test was added in 29be1e5

[mcollina]

CI seems ok.

@lpinca what should I do? CI is passing with this change.

Should I send a PR to fix #19819 (comment)?

[lpinca]

@mcollina yes but by doing that the test fails so I'm not sure if it is working as it was originally intended.

[lpinca]

The following part of the test

node/test/parallel/test-http-dump-req-when-res-ends.js

Lines 17 to 22 in 49e9893

	// end is not called as we are just exhausting
	// the in-memory buffer
	req.on('end', common.mustNotCall);
	// this 'data' handler will be removed when dumped
	req.on('data', common.mustNotCall);

is not testing anything right now.

[mcollina]

Proper fix in #19823.

[Trott]

Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/17718/
Windows CI re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/17018/

[Trott]

CI re-runs are green. Finally landing.

[Trott]

Landed in a639ec4

[mcollina]

I don’t think this was needed at with the other PR. The provided command was running fine on my machine. I’m sorry this was landed without a discussion and/or verifying that the other PR solved the problem first.

[Trott]

I don’t think this was needed at with the other PR. The provided command was running fine on my machine. I’m sorry this was landed without a discussion and/or verifying that the other PR solved the problem first.

I confirmed that the other PR did not fix the problem when multiple tests were running at once.