doc: add comma and colon in message with --inspector doc url#19871
doc: add comma and colon in message with --inspector doc url#19871n-filatov wants to merge 2 commits into
Conversation
cjihrig
left a comment
There was a problem hiding this comment.
Can you drop the trailing slash from the URL? Otherwise, LGTM.
|
@cjihrig Done |
|
cc @nodejs/diagnostics |
|
https://nodejs.org/en/docs/inspector/ redirects to https://nodejs.org/en/docs/guides/debugging-getting-started/ but https://nodejs.org/en/docs/inspector (without the trailing slash) 404's. |
|
Good catch @richardlau. We should keep the existingURL and add the trailing slash, although I think a better solution is for the website to not require the trailing slash. |
|
Returned old URL but with trailing slash. Also created issue in nodejs.org repo to fix this bug. |
|
Super minor nits, but while we're in here, can we add a comma after |
|
(Also: Hi, @Muffassa! Welcome and thanks for the PR! These kinds of changes often attract lots of comments. Don't get discouraged! And thanks again!) |
|
@Trott No problem :) Fixed |
|
nodejs/build#1219 has fixed the redirect for the original URL. |
Would that make this PR unnecessary and close-able? (It seems that way to me, with apologies to @Muffassa for giving them nits/comments and then ultimately not accepting the change, but it happens.) |
|
Oh, actually, those commas are still an improvement, so this could land, probably preferably with the slashes omitted though? |
|
(Commit message will probably need to be updated too.) |
|
Changed commit messages, removed slash in the end of url, changed request message. |
PR-URL: nodejs#19871 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: nodejs#19887 Refs: nodejs#19871 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #19871 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: #19887 Refs: #19871 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
make -j4 test(UNIX), orvcbuild test(Windows) passesWhen i follow link https://nodejs.org/en/docs/inspector i get 404 error. Replaced on https://nodejs.org/en/docs/guides/debugging-getting-started/ with inspect flag documentation