tests/parallel: removes string literals from test-domain-timer.js#20120
Closed
palash25 wants to merge 1 commit into
Closed
tests/parallel: removes string literals from test-domain-timer.js#20120palash25 wants to merge 1 commit into
palash25 wants to merge 1 commit into
Conversation
String literals from two `assert.strictEquals()` calls were removed as these string literals did not match the value of `e.message` when an `AssertionError` occurred. Now the default error message is displayed when an error occurs.
benjamingr
approved these changes
Apr 18, 2018
benjamingr
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
cjihrig
approved these changes
Apr 18, 2018
richardlau
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
Member
Trott
approved these changes
Apr 18, 2018
jasnell
approved these changes
Apr 18, 2018
Member
|
Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/18109/ |
Member
lpinca
approved these changes
Apr 19, 2018
trivikr
pushed a commit
that referenced
this pull request
Apr 20, 2018
String literals from two `assert.strictEquals()` calls were removed as these string literals did not match the value of `e.message` when an `AssertionError` occurred. Now the default error message is displayed when an error occurs. PR-URL: #20120 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
String literals from two `assert.strictEquals()` calls were removed as these string literals did not match the value of `e.message` when an `AssertionError` occurred. Now the default error message is displayed when an error occurs. PR-URL: #20120 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis PR is related to the issue given by nodetodo. cc @Trott