Fix Python detection when depot_tools are in PATH in Windows#22539
Closed
guybedford wants to merge 1 commit into
Closed
Fix Python detection when depot_tools are in PATH in Windows#22539guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
bzoz
approved these changes
Aug 29, 2018
bzoz
left a comment
Contributor
There was a problem hiding this comment.
Can confirm: python.bat in PATH breaks vcbuild, this fixes it.
Member
|
The commit message has to be fixed to adhere to the guidelines (e.g., adding @nodejs/platform-windows @nodejs/build-files PTAL |
refack
approved these changes
Aug 31, 2018
Contributor
|
@guybedford could you add a inline comment as to why the added |
Member
|
(This was not |
Member
|
@addaleax sorry, I missed to start the CI. |
Member
|
@guybedford You’ll need to rebase this to get rid of the CI failures here, sorry. |
Member
|
Ping @guybedford |
Member
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18851/ |
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18852/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 21, 2018
PR-URL: nodejs#22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Member
|
Landed in 1d3e40d |
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the detection of Python for me in Windows.
The issue is I've installed "depot_tools" in path for building v8, and as a result "depot_tools/python.bat" is being found instead and that then causes Node to say it can't find Python.
It's probably only affecting my case, but that is good enough for a PR for me :)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes