Skip to content

doc: update mmarchini's e-mail#22776

Closed
mmarchini wants to merge 2 commits into
nodejs:masterfrom
mmarchini:update-my-email
Closed

doc: update mmarchini's e-mail#22776
mmarchini wants to merge 2 commits into
nodejs:masterfrom
mmarchini:update-my-email

Conversation

@mmarchini

@mmarchini mmarchini commented Sep 9, 2018

Copy link
Copy Markdown
Contributor
Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 9, 2018
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2018

Copy link
Copy Markdown
Collaborator

@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/843/pipeline

addaleax
addaleax approved these changes Sep 9, 2018
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like, you can also add the new email as the first on in .mailmap, similar to what happens in #22771

@addaleax addaleax added the fast-track PRs that do not need to wait for 72 hours to land. label Sep 9, 2018
@mmarchini

mmarchini commented Sep 9, 2018

Copy link
Copy Markdown
Contributor Author

Done, thanks for the tip!

@Trott

Trott commented Sep 9, 2018

Copy link
Copy Markdown
Member

+1 to fast-tracking

Trott pushed a commit to Trott/io.js that referenced this pull request Sep 9, 2018
@mmarchini @Trott
doc: update mmarchini's e-mail
66f563d 
PR-URL: nodejs#22776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott

Trott commented Sep 9, 2018

Copy link
Copy Markdown
Member

Landed in 66f563d

@Trott Trott closed this Sep 9, 2018
@Trott

Trott commented Sep 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

(CI re-run with fixup commit: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/846/pipeline) ✔️

targos pushed a commit that referenced this pull request Sep 10, 2018
@mmarchini @targos
doc: update mmarchini's e-mail
9942117 
PR-URL: #22776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mmarchini @nodejs-github-bot @Trott @addaleax @richardlau @BridgeAR