Skip to content

test: prepare test/testpy/__init__.py for Python 3#24794

Closed
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:Py3-for-test_testpy___init__.py
Closed

test: prepare test/testpy/__init__.py for Python 3#24794
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:Py3-for-test_testpy___init__.py

Conversation

@cclauss

@cclauss cclauss commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

label: python

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2018
@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 7, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 7, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 7, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 7, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

@danbev

danbev commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-aix 🛑
Re-run of failing node-test-commit-aix

@Trott

Trott commented Dec 11, 2018

Copy link
Copy Markdown
Member

"Force a rebuild"? Should we force push that commit out? Or is it valid?

@cclauss

cclauss commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

The code is valid. Ship it!

@Trott

Trott commented Dec 11, 2018

Copy link
Copy Markdown
Member

New CI since we have a new commit AND we've marked that pesky test-cli-syntax as unreliable: https://ci.nodejs.org/job/node-test-pull-request/19431/

@cclauss cclauss force-pushed the Py3-for-test_testpy___init__.py branch from cc4a722 to dda7ca5 Compare December 12, 2018 21:03
@cclauss

cclauss commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

Duplicate: This change has already landed in #24954

@cclauss cclauss closed this Dec 14, 2018
@cclauss cclauss deleted the Py3-for-test_testpy___init__.py branch December 14, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants