Skip to content

tools: bump lint-node-md-cli-rollup to version 2#26441

Merged
refack merged 2 commits into
nodejs:masterfrom
refack:lint-md-rollup2
Mar 9, 2019
Merged

tools: bump lint-node-md-cli-rollup to version 2#26441
refack merged 2 commits into
nodejs:masterfrom
refack:lint-md-rollup2

Conversation

@refack

@refack refack commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Now with minification.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 4, 2019
@refack

refack commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/linting

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2019

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@BridgeAR

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

@refack this needs a rebase

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
refack added 2 commits March 8, 2019 19:02
PR-URL: nodejs#26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: nodejs#26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@refack refack force-pushed the lint-md-rollup2 branch from 7e66df9 to 1acf3b1 Compare March 9, 2019 00:03
@refack

refack commented Mar 9, 2019

Copy link
Copy Markdown
Contributor Author

Linter CI test: https://ci.nodejs.org/job/node-test-linter/26155/ ✔️

@refack refack merged commit 1acf3b1 into nodejs:master Mar 9, 2019
@refack refack deleted the lint-md-rollup2 branch March 9, 2019 00:10
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26441
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants