Skip to content

src: fix SplitString to ignore white spaces#26545

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:master
Closed

src: fix SplitString to ignore white spaces#26545
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:master

Conversation

@himself65

@himself65 himself65 commented Mar 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 9, 2019
@himself65

himself65 commented Mar 9, 2019

Copy link
Copy Markdown
Member Author

try to fix #26521

@targos

targos commented Mar 9, 2019

Copy link
Copy Markdown
Member

Could you write a test?

@himself65

himself65 commented Mar 9, 2019

Copy link
Copy Markdown
Member Author

Could you write a test?

I will try :)

BridgeAR
BridgeAR reviewed Mar 9, 2019
View reviewed changes
Comment thread test/parallel/test-cli-node-options.js Outdated
@BridgeAR

BridgeAR commented Mar 10, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21391/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
XadillaX
XadillaX approved these changes Mar 12, 2019
View reviewed changes

@XadillaX XadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev

danbev commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

Landed in 17ab2ed.

@danbev danbev closed this Mar 13, 2019
danbev pushed a commit that referenced this pull request Mar 13, 2019
@himself65 @danbev
src: fix SplitString to ignore white spaces
17ab2ed 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@himself65 himself65 mentioned this pull request Mar 13, 2019
Closed
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
48a8562 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
2733e2d 
PR-URL: nodejs#26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@himself65 @BridgeAR
src: fix SplitString to ignore white spaces
bc09d2f 
PR-URL: #26545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@XadillaX XadillaX XadillaX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@himself65 @targos @BridgeAR @danbev @addaleax @cjihrig @XadillaX @richardlau @nodejs-github-bot