net: autoDestroy Socket#31806
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Collaborator
0117c05 to
daabdb1
Compare
Collaborator
Member
Author
|
If backporting |
Member
|
I prefer this to land as a semver-major commit. |
Collaborator
addaleax
approved these changes
Feb 15, 2020
Collaborator
lpinca
previously approved these changes
Feb 16, 2020
lundibundi
approved these changes
Feb 16, 2020
Collaborator
Member
Author
|
CI passes |
Member
Author
Member
Author
|
Seems to be quite a bit of failures on CITGM though I don't think they are related to this PR. I'd appreciate a second opinion @Trott @MylesBorins. #31806 (comment) |
Member
Author
|
Nevermind, CITGM looks good. This PR actually has fever failures than master (for some reason?). |
Member
|
@nodejs/tsc this needs another approval. |
addaleax
approved these changes
Apr 2, 2020
Member
There was a problem hiding this comment.
I’m not sure I understand why this is necessary either, but I agree that the test functionality shouldn’t be affected – the important thing is that the .once('error') handler below fires.
Member
Author
|
Landed in efefdd6 |
ronag
added a commit
that referenced
this pull request
Apr 2, 2020
Refactors net.Socket into using autoDestroy functionality of streams. PR-URL: #31806 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 12, 2020
4 tasks
ronag
referenced
this pull request
Apr 28, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
4 tasks
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2020
Set `allowHalfOpen: true` in the client. Fixes: nodejs#29802 Refs: nodejs#31806
2 tasks
This was referenced Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors net.Socket into using autoDestroy functionality of streams.
During this refactoring due to slightly different timing of things other bugs got activated and needed to be resolved.Also, the behaviour ofnet.Socketandstream.Duplexneeded to be consolidated to have the same generic behaviour in terms ofallowHalfOpen.Also fixes a close vs shutdown race #32486 (comment)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes