Skip to content

tools: update ESLint to 7.0.0-alpha.3#32533

Closed
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:eslint
Closed

tools: update ESLint to 7.0.0-alpha.3#32533
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

@cjihrig cjihrig commented Mar 28, 2020

Copy link
Copy Markdown
Contributor

Update ESLint to 7.0.0-alpha.3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 28, 2020

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@cjihrig

cjihrig commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

The only remaining CI failure is:

ssh: Could not resolve hostname github.com: Name or service not known

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member

Landed in 23a3408

@addaleax addaleax closed this Apr 2, 2020
@cjihrig cjihrig deleted the eslint branch April 2, 2020 23:28
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants