[v12.x backport] CJS exports detection#35405
Conversation
|
Review requested:
|
3627a5a to
0e3380a
Compare
GeoffreyBooth
left a comment
There was a problem hiding this comment.
Approving that these PRs should be backported; haven’t specifically re-reviewed the code since the original PRs.
|
@guybedford can you rebase this? |
PR-URL: nodejs#35249 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: nodejs#35426 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
0e3380a to
0708932
Compare
|
@codebytere sure, thanks for looking into this, I've rebased the commits. |
|
Landed in 2f3ffc0...5357a05 |
PR-URL: #35249 Backport-PR-URL: #35405 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
@codebytere we need to also include #35483 and preferably #35501 as well. When is the 12.x release planned for? We may want to bump some of the modules changes that only came out last week if we can have them bake a bit longer. |
|
_@MylesBorins it's slated for tues 10/6 - what are your thoughts for which to bump? we could either
|
|
There are a bunch of modules backports that were part of this and the prior PR that have not been on Current for two weeks (they went out last week). Even if we bump a week some of the fixes haven't gone out yet. Are we still planning one more minor before maintenance? |
|
Closing in favor of #35757 |
This backports the CJS exports detection from #35249 and the error message adjustments from #35426 for 12.x.
This PR is based to the modules backports PR at #35385 so should land after that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes