Skip to content

test: fix inconsistent styling in test-url#5014

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:test-url-consistent-style
Closed

test: fix inconsistent styling in test-url#5014
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:test-url-consistent-style

Conversation

@mscdex

@mscdex mscdex commented Jan 31, 2016

Copy link
Copy Markdown
Contributor

Some property names were unnecessarily quoted and there were also unnecessary spaces throughout.

@mscdex mscdex added url Issues and PRs related to the legacy built-in url module. test Issues and PRs related to the tests. labels Jan 31, 2016
@mscdex

mscdex commented Jan 31, 2016

Copy link
Copy Markdown
Contributor Author

@mscdex

mscdex commented Jan 31, 2016

Copy link
Copy Markdown
Contributor Author

CI is green except for one infrastructure-related CI failure.

@Trott

Trott commented Jan 31, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments
@JungMinu

JungMinu commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM

@jasnell

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

Landed in 1684957

@jasnell

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

lts-watch label applied :-)

@mscdex mscdex deleted the test-url-consistent-style branch February 7, 2016 19:04
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#5014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants