stream: error callbacks after destroy during write/final#63862
Open
cjc0013 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writable streams can be destroyed inside user-provided
_write()or_final()implementations before their callback runs. In that gap, the callback could previously continue the write/final completion path as a success even though the stream had already been destroyed.This change checks for destruction when those callbacks return. If the stream was destroyed without an explicit error, the write or end callback receives
ERR_STREAM_DESTROYED, which follows the issue guidance to cancel the remaining completion work and turn a silent destroy into an error.Validation:
node --check lib/internal/streams/writable.js,node --check test/parallel/test-stream-writable-destroy.js,node --check test/parallel/test-stream-writable-final-destroy.js, andgit diff --check.Refs: #39030