test: favor === over == in test-timers.js#8131
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Member
|
Love the PR title. ;) LGTM… how bad would it be to do all of those in a bulk update? |
== over == in test-timers.js=== over == in test-timers.js
Use `===` instead of `==` in pummel/test-timers.js
Member
Author
|
@addaleax asked:
Hard to say. Might be fine. Or it might be hard to review because it will be a mix of:
It will probably be more straightforward in the tests than in the instances in lib. I was pondering both doing one big PR and also going the other way and suggesting that people do individual files as a good first contribution. |
Member
|
@Trott Mh yeah, you can probably judge that best. It just seems like a lot of overhead on your part to me. :) |
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Member
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 18, 2016
Use `===` instead of `==` in pummel/test-timers.js PR-URL: nodejs#8131 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in d52ceb4 |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
Use `===` instead of `==` in pummel/test-timers.js PR-URL: #8131 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Use `===` instead of `==` in pummel/test-timers.js PR-URL: #8131 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Use `===` instead of `==` in pummel/test-timers.js PR-URL: #8131 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Use `===` instead of `==` in pummel/test-timers.js PR-URL: #8131 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test timers
Description of change
Use
===instead of==in pummel/test-timers.js