Skip to content

Improve Persian translation#1871

Closed
armanatory wants to merge 10 commits into
nodejs:masterfrom
armanatory:master
Closed

Improve Persian translation#1871
armanatory wants to merge 10 commits into
nodejs:masterfrom
armanatory:master

Conversation

@armanatory

Copy link
Copy Markdown

minor fixes in persian translation

@fhemberger fhemberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't submit:

  • Editor config files (VS Code)
  • Blog posts (locale/fa/blog), those remain untranslated.

@fhemberger fhemberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all files locale/.vs/ from the PR.

Comment thread locale/fa/docs/index.md

<ul>
<li><a href="https://nodejs.org/docs/latest-v9.x/api/">Node.js 9.x</a></li>
<<<<<<< HEAD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these git merge artifacts.

Comment thread locale/fa/site.json
{
"title": "Node.js",
"author": "Node.js Foundation",
<<<<<<< HEAD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these git merge artifacts.

@@ -0,0 +1,6 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all files in locale/.vs/ from the PR.

Comment thread locale/fa/blog/index.md
@@ -0,0 +1,4 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove locale/fa/blog/index.md.

@@ -0,0 +1,54 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove locale/fa/blog/nodejs-road-ahead.md.

Comment thread locale/fa/site.json
@@ -1,9 +1,14 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the "blog" key here, it won't show up in the local navigation.

"blog": {

@fhemberger

Copy link
Copy Markdown
Contributor

Closed in favor of #1866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants