React 16#445
Merged
Merged
Conversation
|
This is great Dustin, would love to see this merged into a release. |
e130fbb to
0bd9e36
Compare
Contributor
Author
|
@Daniel15 this is almost ready to go. I just have to finish getting the webpack sample working before this should be merged, everything else is ready for review |
Contributor
Author
|
@Daniel15 this should be good to go now. |
Contributor
|
Thank you @dustinsoftware! I'll try to push out a release this weekend. |
Contributor
|
Released this today as version 3.2. Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples still need to be updated. This updates the built-in copy of React. The MVC Core sample was updated to support PropTypes and ES6 classes, both of which are required for React 16.
CommonJS imports are still not supported with built-in babel. I'm not sure how many people still need that functionality since compiling the client + server bundle with webpack ahead of time is a pretty stable alternative. So, it may be worth it to just deprecate on-the-fly JS compiler and move ahead with webpack-only builds.