Skip to content

Cannot allow nil at year#1771

Merged
soutaro merged 1 commit into
ruby:masterfrom
ksss:time-new-year
Mar 22, 2024
Merged

Cannot allow nil at year#1771
soutaro merged 1 commit into
ruby:masterfrom
ksss:time-new-year

Conversation

@ksss

@ksss ksss commented Mar 20, 2024

Copy link
Copy Markdown
Collaborator 
Time.new(nil)
#=> <internal:timev>:413:in `initialize': no implicit conversion of nil into Integer (TypeError)

@soutaro soutaro added this to the RBS 3.5 milestone Mar 22, 2024
@soutaro soutaro added this pull request to the merge queue Mar 22, 2024
soutaro
soutaro approved these changes Mar 22, 2024
View reviewed changes

@soutaro soutaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merged via the queue into ruby:master with commit 501eea9 Mar 22, 2024
@ksss ksss deleted the time-new-year branch March 22, 2024 01:22
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

No one assigned

Labels

Released PRs already included in the released version

Projects

None yet

Milestone

RBS 3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@ksss @soutaro