Skip to content

Fix SEGV with parse negative position#1790

Merged
soutaro merged 1 commit into
ruby:masterfrom
ksss:parser-segv
Apr 6, 2024
Merged

Fix SEGV with parse negative position#1790
soutaro merged 1 commit into
ruby:masterfrom
ksss:parser-segv

Conversation

@ksss

@ksss ksss commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I've found the following cases. It will raise SEGV.

RBS::Parser.parse_type("a", range: -2...-1)

soutaro
soutaro approved these changes Apr 6, 2024
View reviewed changes

@soutaro soutaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.5 milestone Apr 6, 2024
@soutaro soutaro added this pull request to the merge queue Apr 6, 2024
Merged via the queue into ruby:master with commit 0b31458 Apr 6, 2024
@ksss ksss deleted the parser-segv branch April 6, 2024 01:44
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

No one assigned

Labels

Released PRs already included in the released version

Projects

None yet

Milestone

RBS 3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@ksss @soutaro