Skip to content

Fix extensions not applying to defaultDialect relative paths#775

Merged
jviotti merged 2 commits into
mainfrom
default-dialect-extensions
Jun 10, 2026
Merged

Fix extensions not applying to defaultDialect relative paths#775
jviotti merged 2 commits into
mainfrom
default-dialect-extensions

Conversation

@jviotti

@jviotti jviotti commented Jun 10, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/utils.h Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jun 10, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR fixes how the CLI resolves relative defaultDialect values so that extension handling and the configuration base path behave consistently.

Changes:

  • Clarifies in the docs that relative defaultDialect resolution is based on the directory containing jsonschema.json (and is not shifted by the path property).
  • Extends resolve_relative_uri to optionally try configured/default schema extensions when a relative path is provided without an extension.
  • Updates default_dialect to pass the parsed extensions (from CLI/config) into relative resolution, while leaving absolute URIs untouched.
  • Adds new inspect shell tests covering “no base shift”, extension fallbacks for JSON/YAML/custom extensions, and CLI --default-dialect fallback behavior.

Technical Notes: Extension fallback uses the merged extension set from CLI and configuration, defaulting to .json/.yaml/.yml when none is configured.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/utils.h
@jviotti jviotti merged commit 749915d into main Jun 10, 2026
18 of 28 checks passed
@jviotti jviotti deleted the default-dialect-extensions branch June 10, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant