Make use of NSURLSession and WinHTTP on macOS and Windows

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.

[cubic-dev-ai]

5 issues found across 96 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/http/http_darwin.mm">

<violation number="1" location="src/http/http_darwin.mm:80">
P2: This backend drops duplicate response headers by reading `allHeaderFields` from a dictionary. It violates `HTTPResponse` contract to preserve repeated headers and can lose semantics for headers that must not be comma-folded.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: This backend drops duplicate response headers by reading allHeaderFields from a dictionary. It violates HTTPResponse contract to preserve repeated headers and can lose semantics for headers that must not be comma-folded.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/http/http_darwin.mm, line 80:

<comment>This backend drops duplicate response headers by reading `allHeaderFields` from a dictionary. It violates `HTTPResponse` contract to preserve repeated headers and can lose semantics for headers that must not be comma-folded.</comment>

<file context>
@@ -0,0 +1,109 @@
+                const auto *http_response{(NSHTTPURLResponse *)raw_response};
+                response_pointer->status = http_status_from_code(
+                    static_cast<std::uint16_t>(http_response.statusCode));
+                [http_response.allHeaderFields
+                    enumerateKeysAndObjectsUsingBlock:^(
+                        NSString *name, NSString *value, BOOL *) {
</file context>