This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Use updates.codegate.ai for /versions instead of GitHub#1264
Merged
Conversation
dmjb
commented
Mar 11, 2025
| from typing import Sequence, Union | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa |
Contributor
Author
There was a problem hiding this comment.
Some changes like this were the result of applying the linter.
Wire up CodeGate to use the new update service to determine the latest version. This is kept behind a config flag, but I have tested locally.
dd1cec1 to
1e27b1d
Compare
dmjb
commented
Mar 11, 2025
| config.server_key = os.environ["CODEGATE_SERVER_KEY"] | ||
| if "CODEGATE_FORCE_CERTS" in os.environ: | ||
| config.force_certs = os.environ["CODEGATE_FORCE_CERTS"] | ||
| config.force_certs = cls.__bool_from_string(os.environ["CODEGATE_FORCE_CERTS"]) |
Contributor
Author
There was a problem hiding this comment.
Fix for a bug I spotted while working on this part of the code: force_certs expects a bool, but in this line we assign a string to the value. The likely consequence of this is that if someone explicitly sets this value to false in an env var, it will end up evaluating to True when treated as a boolean.
alex-mcgovern
approved these changes
Mar 11, 2025
alex-mcgovern
left a comment
Contributor
There was a problem hiding this comment.
Didn't spot anything weird — looks good to me, frontend still works.
Only question is do we need the config flag? Can we not just validate roughly on this branch and include in next release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up CodeGate to use the new update service to determine the latest version. This is kept behind a config flag, but I have tested locally.