Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Pii Pipeline#919

Merged
lukehinds merged 13 commits into
mainfrom
pii-pipe
Feb 10, 2025
Merged

Pii Pipeline#919
lukehinds merged 13 commits into
mainfrom
pii-pipe

Conversation

@lukehinds

Copy link
Copy Markdown

Initial implementation of the PII pipelline

Comment thread prompts/default.yaml
Comment thread src/codegate/pipeline/pii/analyzer.py
Comment thread src/codegate/pipeline/pii/pii.py
Comment thread src/codegate/pipeline/pii/analyzer.py
Comment thread src/codegate/pipeline/pii/pii.py
Comment thread src/codegate/pipeline/pii/pii.py Outdated

@jhrozek jhrozek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, left a couple of comments.

We don't have to fix up everything now, I know we have a cleanup lined up.

@jhrozek

jhrozek commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

I also see a bunch of these in the logs:

2025-02-06T11:42:45.266370Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: es, registry supported la
nguages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils.py
2025-02-06T11:42:45.268406Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: it, registry supported languages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils
.py                                                                                                                                                                                         2025-02-06T11:42:45.270470Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: pl, registry supported la
nguages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils.py

@lukehinds

Copy link
Copy Markdown
Author

I also see a bunch of these in the logs:

2025-02-06T11:42:45.266370Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: es, registry supported la
nguages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils.py
2025-02-06T11:42:45.268406Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: it, registry supported languages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils
.py                                                                                                                                                                                         2025-02-06T11:42:45.270470Z [warning  ] Recognizer not added to registry because language is not supported by registry - CreditCardRecognizer supported languages: pl, registry supported la
nguages: en lineno=119 module=recognizers_loader_utils pathname=/Users/jakub/devel/codegate/venv/lib/python3.12/site-packages/presidio_analyzer/recognizer_registry/recognizers_loader_utils.py

We can ignore these.

Comment thread src/codegate/pipeline/pii/analyzer.py
Comment thread pyproject.toml Outdated
aponcedeleonch
aponcedeleonch previously approved these changes Feb 10, 2025

@aponcedeleonch aponcedeleonch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments but nothing major. I think we can take care of them in future PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants